Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS
gerrit-no-reply at lists.osmocom.org
Fri Apr 12 03:52:37 UTC 2019
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13173 )
Change subject: sms queue: avoid repeated Paging for a failed SMS
sms queue: avoid repeated Paging for a failed SMS
So far, sms_pending_failed() starts a new sms_queue_trigger() run. The
intention behind that might have been to fill up the queue when sending SMS has
failed, but the practical effect is actually bad:
As current ttcn3-msc-test runs show, a failed MT SMS gets triggered multiple
times in short succession, i.e. osmo-msc repeatedly sends Paging Requests for
the same subscriber.
This special case happens actually only when there are few SMS still in the DB
to be delivered. In the TTCN3 test, there is exactly one MT SMS for one
subscriber, and retriggering the queue brings up the same SMS every time.
See f_tc_lu_and_mt_sms_paging_and_nothing() and f_tc_sgsap_mt_sms_and_nothing()
"/* Expect the MSC to page exactly 10 times before giving up */"
This is bad because an MSC should send a Paging Request exactly once. Retrying
failed Paging is clearly the task of the BSC, not the MSC. The remaining code
around Paging correctly follows this paradigm, but this retrigger doesn't.
Do not immediately trigger the SMS queue on a failed MT SMS. Instead, leave it
up to the periodical SMS queue trigger to decide.
This patch will cause the MT SMS tests in ttcn3-msc-tests to fail, because the
test expectations are bogus. The patch fixing the test run is listed 'Related'
Related: I7dce12942a65eaaf97f78ca69401c7f93faacb9e (osmo-ttcn3-hacks)
1 file changed, 0 insertions(+), 1 deletion(-)
Jenkins Builder: Verified
Neels Hofmeyr: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, but someone else must approve
Keith Whyte: Looks good to me, but someone else must approve
diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c
index afd878f..4de30ad 100644
@@ -161,7 +161,6 @@
smsq->pending -= 1;
To view, visit https://gerrit.osmocom.org/13173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log