Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Apr 11 17:30:50 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13597 )

Change subject: Makefile.common.inc: add {,un}install targets
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc
File build/Makefile.common.inc:

https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@34
PS1, Line 34: 	if [ "$(OSMO_GSM_MANUALS_NO_INSTALL)" != "1" ]; then \
According to configure.ac in osmo-bsc, default is not building manuals, so I think this should also be "don't install by default", that is: var must be set explicitly to 1 to have pdf installed. Otherwise please provide some reasoning why is it enabled by default.

>From osmo-bsc.git/configure.ac:
# Generate manuals
AC_ARG_ENABLE(manuals,
	[AS_HELP_STRING(
		[--enable-manuals],
		[Generate manual PDFs [default=no]],
	)],


https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@36
PS1, Line 36: Dm6
Probably better using /share/doc/osmo-gsm-manuals/. since we use for instance /usr/share/doc/osmo-bsc/ for osmo-bsc (unless of course you know how to easily pass by "osmo-bsc" from main Makefile to this one).



-- 
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Apr 2019 17:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/88f42316/attachment.html>


More information about the gerrit-log mailing list