Change in osmo-hlr[master]: osmo-hlr: allow configuring db path from cfg file

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Apr 11 17:03:25 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13586 )

Change subject: osmo-hlr: allow configuring db path from cfg file
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13586/1/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13586/1/src/hlr.c@739
PS1, Line 739: osmo_talloc_replace_string
> Can we do this conditionally after parsing the VTY config?
Makes sense, took me a while to understand what you mean.

Best option is to do in line 778 (removing the if clause):
osmo_talloc_replace_string(g_hlr, &g_hlr->db_file_path, cmdline_opts.db_file ? : HLR_DEFAULT_DB_FILE_PATH);



-- 
To view, visit https://gerrit.osmocom.org/13586
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87b8673324e1e6225afb758fb4963ff3279ea3d8
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 17:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/20a77d18/attachment.html>


More information about the gerrit-log mailing list