Change in osmo-ggsn[master]: ggsn: Remove magic numbers from ipcp_contains_option()

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Apr 11 14:21:49 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13569 )

Change subject: ggsn: Remove magic numbers from ipcp_contains_option()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13569/1/ggsn/ggsn.c
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/13569/1/ggsn/ggsn.c@419
PS1, Line 419: 	const uint8_t *cur_opt = ipcp + sizeof(struct ipcp_hdr);
Same as with previous commit: we can drop cur_opt completely.



-- 
To view, visit https://gerrit.osmocom.org/13569
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b1abc6f403f85986407e9e8359924dfcb58031a
Gerrit-Change-Number: 13569
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Apr 2019 14:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/be2f7cc4/attachment.html>


More information about the gerrit-log mailing list