Change in libosmocore[master]: GSUP: add Class IE

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Apr 11 08:54:47 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13576 )

Change subject: GSUP: add Class IE
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@71
PS3, Line 71: OSMO_GSUP_CLASS_IE
Looking at this IE, the reader may ask: class of what?
How about 'OSMO_GSUP_MSG_CLASS_IE' or 'OSMO_GSUP_MESSAGE_CLASS_IE'?


https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@233
PS3, Line 233: osmo_gsup_class
Same comment regarding the naming here.


https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@241
PS3, Line 241: OSMO_GSUP_CLASS_ARRAYSIZE
Which array?

Enum osmo_gsup_iei has '_OSMO_GSUP_IEI_END_MARKER'.
I think we should keep the naming style consistent.



-- 
To view, visit https://gerrit.osmocom.org/13576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef
Gerrit-Change-Number: 13576
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 08:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/6b93929c/attachment.html>


More information about the gerrit-log mailing list