Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Apr 11 08:25:22 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13006 )

Change subject: hlr.c: forward GSUP messages between clients
......................................................................


Patch Set 8:

(3 comments)

https://gerrit.osmocom.org/#/c/13006/8/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13006/8/src/hlr.c@478
PS8, Line 478: Cannot forward GSUP
All "GSUP message forwarding error" messages in this function look different. This one is missing IMSI. Let's unify the message format for all LOGP() calls, for example:

  "GSUP message (IMSI-%imsi, kind=%kind, type=%type) forwarding error: REASON"

This can be done using #define LOGP_GSUP(msg, fmt, ##args ...).


https://gerrit.osmocom.org/#/c/13006/8/src/hlr.c@483
PS8, Line 483: LOGL_NOTICE
Let's rather use LOGL_INFO. GSUP message forwarding is an expected event, and may happen quite often, so there is no need to distract log reader's attention.


https://gerrit.osmocom.org/#/c/13006/8/src/hlr.c@494
PS8, Line 494: gsup = NULL;
The argument is defined as follows:

  *const* struct osmo_gsup_message *gsup,

so why do we need to forget this pointer?



-- 
To view, visit https://gerrit.osmocom.org/13006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 8
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 08:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/4f0747d0/attachment.html>


More information about the gerrit-log mailing list