Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

osmith gerrit-no-reply at lists.osmocom.org
Thu Apr 11 07:57:40 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13006 )

Change subject: hlr.c: forward GSUP messages between clients
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.osmocom.org/#/c/13006/7/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13006/7/src/hlr.c@488
PS7, Line 488: and
typo: and -> an

(I'm quickly fixing this myself.)


https://gerrit.osmocom.org/#/c/13006/7/src/hlr.c@491
PS7, Line 491: MAY BE DEALLOCATED
Just to make sure I understand this right: msg is either free'd up directly (if an error occurs), or it gets added to the (struct ipa_server_conn) conn->tx_queue, and will eventually get sent and then deallocated in the main loop. Is that accurate?



-- 
To view, visit https://gerrit.osmocom.org/13006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 07:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/24cddf58/attachment.html>


More information about the gerrit-log mailing list