Change in osmo-ttcn3-hacks[master]: SGsAP_Templates: Remove invalid template.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 11 07:28:10 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13556 )

Change subject: SGsAP_Templates: Remove invalid template.
......................................................................

SGsAP_Templates: Remove invalid template.

The Template tr_SGsAP_RESET_IND is invalid since it requires vlr and mme
name at once, which is not a valid constellation in the real world. Lets
have two separate templates, one for MME and VLR, just like we have it
already with the ts_ versions of the templates.

Change-Id: Ifdf6030bb42ebd99c2030d600e87127e3619d7ad
Related: OS#3859
---
M library/SGsAP_Templates.ttcn
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved
  Harald Welte: Looks good to me, approved



diff --git a/library/SGsAP_Templates.ttcn b/library/SGsAP_Templates.ttcn
index 457481e..428924f 100644
--- a/library/SGsAP_Templates.ttcn
+++ b/library/SGsAP_Templates.ttcn
@@ -659,10 +659,18 @@
 		vLR_Name := ts_SGsAP_IE_VlrName(vlr_name)
 	}
 }
-template PDU_SGsAP tr_SGsAP_RESET_IND(template octetstring mme_name, template octetstring vlr_name) := {
+
+template PDU_SGsAP tr_SGsAP_RESET_IND_MME(template octetstring mme_name) := {
 	sGsAP_RESET_INDICATION := {
 		messageType := '00010101'B,
 		mME_Name := tr_SGsAP_IE_MmeName(mme_name),
+		vLR_Name := omit
+	}
+}
+template PDU_SGsAP tr_SGsAP_RESET_IND_VLR(template octetstring vlr_name) := {
+	sGsAP_RESET_INDICATION := {
+		messageType := '00010101'B,
+		mME_Name := omit,
 		vLR_Name := tr_SGsAP_IE_VlrName(vlr_name)
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/13556
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdf6030bb42ebd99c2030d600e87127e3619d7ad
Gerrit-Change-Number: 13556
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/d0ba0d3f/attachment.html>


More information about the gerrit-log mailing list