Change in osmo-bts[master]: oc2gbts_mgr: use osmo_init_logging2() instead of osmo_init_logging()

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Apr 11 03:20:37 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13275 )

Change subject: oc2gbts_mgr: use osmo_init_logging2() instead of osmo_init_logging()
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13275/4/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c
File src/osmo-bts-oc2g/misc/oc2gbts_mgr.c:

https://gerrit.osmocom.org/#/c/13275/4/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c@264
PS4, Line 264: mgr_log_init
BTW: what are the benefit(s) of having this function? It basically calls osmo_init_logging2(), so why not to call it directly from main()? Not related to this change, can be done separately...



-- 
To view, visit https://gerrit.osmocom.org/13275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc80cd1f77f10a879d4536d788377f522dd853f
Gerrit-Change-Number: 13275
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 03:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/a5d5fd6f/attachment.html>


More information about the gerrit-log mailing list