Change in libosmo-abis[master]: ipa_keepalive_fsm: Suppress error messages for INIT -> INIT transition

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 11 00:26:08 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13541 )

Change subject: ipa_keepalive_fsm: Suppress error messages for INIT -> INIT transition
......................................................................

ipa_keepalive_fsm: Suppress error messages for INIT -> INIT transition

If we receive an OSMO_IPA_KA_E_STOP in INIT state, we are trying to
re-enter INIT, which is not permitted as per the FSM definition.

Adding this permission avoids the below error message from hitting the
logs every time this happens:

<0003> input/ipa_keepalive.c:158 IPA-KEEPALIVE(server)[0x612000000520]{INIT}: transition to state INIT not permitted!

Change-Id: I8db2f2e708fc4fbb81f5019973098a80e8f540d2
---
M src/input/ipa_keepalive.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c
index 6467720..81b5a26 100644
--- a/src/input/ipa_keepalive.c
+++ b/src/input/ipa_keepalive.c
@@ -167,7 +167,7 @@
 	[OSMO_IPA_KA_S_INIT] = {
 		.name = "INIT",
 		.in_event_mask = S(OSMO_IPA_KA_E_START),
-		.out_state_mask = S(OSMO_IPA_KA_S_WAIT_RESP),
+		.out_state_mask = S(OSMO_IPA_KA_S_WAIT_RESP) | S(OSMO_IPA_KA_S_INIT),
 		.action = ipa_ka_init,
 	},
 	[OSMO_IPA_KA_S_IDLE] = {

-- 
To view, visit https://gerrit.osmocom.org/13541
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8db2f2e708fc4fbb81f5019973098a80e8f540d2
Gerrit-Change-Number: 13541
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/baddb781/attachment.html>


More information about the gerrit-log mailing list