Change in libosmocore[master]: add osmo_{escape, quote}_str_buf2() for OSMO_STRBUF_APPEND() use

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Apr 10 23:23:44 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13573 )

Change subject: add osmo_{escape,quote}_str_buf2() for OSMO_STRBUF_APPEND() use
......................................................................


Patch Set 1:

> I see some overlap here with my _buf changes

I noticed the overlap with commit "osmo_escape_str_buf: Always copy, don't return input string pointer" -- this patch existed before you merged that, and this patch had the exact same changes to osmo_escape_str_buf() in it. After that I stripped this commit log msg.

Now noticing the commit "Add _buf() functions to bypass static string buffers" is also merged.

I should have another close look...


-- 
To view, visit https://gerrit.osmocom.org/13573
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id748b906b0083b1f1887f2be7a53cae705a8a9ae
Gerrit-Change-Number: 13573
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 10 Apr 2019 23:23:44 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190410/19173832/attachment.html>


More information about the gerrit-log mailing list