Change in libosmocore[master]: GSUP: add Kind IE

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 10 22:47:40 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13576 )

Change subject: GSUP: add Kind IE
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13576/1/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/13576/1/include/osmocom/gsm/gsup.h@234
PS1, Line 234: OSMO_GSUP_KIND_UNSET
I would prefer "message class" over "message kind".  There's already several 3GPP protocols we deal with (among those, Abis OML) where there's a message class and a message type, and hence the class already has some pre-existing notion/definition.  Alternatively, one could also call it subsystem or the like, but I think class is quite ok?



-- 
To view, visit https://gerrit.osmocom.org/13576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef
Gerrit-Change-Number: 13576
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 10 Apr 2019 22:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190410/4d7e020d/attachment.html>


More information about the gerrit-log mailing list