Change in osmo-hlr[master]: add missing error log: invalid IMSI

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Apr 10 18:03:09 UTC 2019


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13587


Change subject: add missing error log: invalid IMSI
......................................................................

add missing error log: invalid IMSI

Change-Id: I65e9ecac06dc6d1abb9802d621c385d3b4fab83a
---
M src/hlr.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/87/13587/1

diff --git a/src/hlr.c b/src/hlr.c
index 836d57b..2614f35 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -533,8 +533,10 @@
 
 	/* 3GPP TS 23.003 Section 2.2 clearly states that an IMSI with less than 5
 	 * digits is impossible.  Even 5 digits is a highly theoretical case */
-	if (strlen(gsup.imsi) < 5)
+	if (strlen(gsup.imsi) < 5) {
+		LOGP(DMAIN, LOGL_ERROR, "IMSI too short: %s\n", osmo_quote_str(gsup.imsi, -1));
 		return gsup_send_err_reply(conn, gsup.imsi, gsup.message_type, GMM_CAUSE_INV_MAND_INFO);
+	}
 
 	if (gsup.destination_name_len)
 		return read_cb_forward(conn, msg, &gsup);

-- 
To view, visit https://gerrit.osmocom.org/13587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65e9ecac06dc6d1abb9802d621c385d3b4fab83a
Gerrit-Change-Number: 13587
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190410/ad853b4a/attachment.html>


More information about the gerrit-log mailing list