Change in osmo-msc[master]: smpp: Make libsmpp34 use talloc for its allocations

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Apr 10 13:16:11 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13562 )

Change subject: smpp: Make libsmpp34 use talloc for its allocations
......................................................................


Patch Set 2:

(1 comment)

Was there some communication with the original author before you changed API names? This is confusing for reviewers and a bit rude imho, specially since you didn't explain your intention with this kind of change.

https://gerrit.osmocom.org/#/c/13562/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13562/2//COMMIT_MSG@9
PS2, Line 9: We are just introducing smpp34_set_memory_functions() in libsmpp34
You forgot to update this reference when changing API names



-- 
To view, visit https://gerrit.osmocom.org/13562
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2725ffab6a225813e65768735f01678e2022128
Gerrit-Change-Number: 13562
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Apr 2019 13:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190410/d6c5c4d5/attachment.html>


More information about the gerrit-log mailing list