Change in osmo-msc[master]: sms_queue: Print dest msisdn instead of unknown subscriber

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 9 22:17:50 UTC 2019


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13554 )

Change subject: sms_queue: Print dest msisdn instead of unknown subscriber
......................................................................

sms_queue: Print dest msisdn instead of unknown subscriber

If subscriber is NULL, vlr_subscr_msisdn_or_name() returns string
"unknown", which is less informative than printing destination msisdn
expected for the queued sms.
This happens for instance if an sms was queued with Store&Forward and
destination subscriber is not currently registered

Change-Id: I4b8b54c9c41b17d4e1fa7ece63aa91a98036ef11
---
M src/libmsc/sms_queue.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c
index 274c712..afd878f 100644
--- a/src/libmsc/sms_queue.c
+++ b/src/libmsc/sms_queue.c
@@ -228,8 +228,10 @@
 		/* Is the subscriber attached? If not, go to next SMS */
 		if (!sms->receiver || !sms->receiver->lu_complete) {
 			LOGP(DLSMS, LOGL_DEBUG,
-			     "Subscriber %s is not attached, skipping SMS %llu\n",
-			     vlr_subscr_msisdn_or_name(sms->receiver), sms->id);
+			     "Subscriber %s%s is not attached, skipping SMS %llu\n",
+			     sms->receiver ? "" : "MSISDN-",
+			     sms->receiver ? vlr_subscr_msisdn_or_name(sms->receiver)
+					   : sms->dst.addr, sms->id);
 			sms_free(sms);
 			continue;
 		}

-- 
To view, visit https://gerrit.osmocom.org/13554
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b8b54c9c41b17d4e1fa7ece63aa91a98036ef11
Gerrit-Change-Number: 13554
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190409/6a533fe6/attachment.html>


More information about the gerrit-log mailing list