Change in osmo-hlr[master]: USSD: save MO USSD's originating MSC's vlr_number

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Apr 9 13:15:57 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13515 )

Change subject: USSD: save MO USSD's originating MSC's vlr_number
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13515/12/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13515/12/src/hlr_ussd.c@247
PS12, Line 247: 		ss->vlr_number_len = strlen(subscr.vlr_number) + 1;
reading this still hurts my eyes. I wish we could get rid of this weird duality, but ok for sake of not blocking this patch on a completely separate issue.



-- 
To view, visit https://gerrit.osmocom.org/13515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1
Gerrit-Change-Number: 13515
Gerrit-PatchSet: 12
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Apr 2019 13:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190409/cefb3846/attachment.html>


More information about the gerrit-log mailing list