Change in osmo-hlr[master]: USSD: save MO USSD's originating MSC's vlr_number

osmith gerrit-no-reply at lists.osmocom.org
Tue Apr 9 11:01:29 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13515 )

Change subject: USSD: save MO USSD's originating MSC's vlr_number
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.osmocom.org/#/c/13515/10/src/gsup_router.c
File src/gsup_router.c:

https://gerrit.osmocom.org/#/c/13515/10/src/gsup_router.c@50
PS10, Line 50: gsup_route_find_by_conn
> Doxygen comment is missing.
Done


https://gerrit.osmocom.org/#/c/13515/10/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13515/10/src/hlr_ussd.c@566
PS10, Line 566: LOGPSS(ss, LOGL_DEBUG, "Destination IPA name retrieved from GSUP route: %s\n",
              : 					       osmo_quote_str((const char *)ss->vlr_number, ss->vlr_number_len));
> Did you check if TTCN-3 test cases pass after this change? […]
Neels also pointed this out and I thought it was only needed for USSD. But you are right, it is needed for the unstructured SS too, or else the TTCN3 test will fail. This is fixed in patchset 11. Also all TTCN3 tests pass there again.

Regarding TTCN3, it would have been better if I also checked the previous patch that has been merged to master [1], because this one causes several failures. Probably because vlr_number is not set in the testdb that osmo-hlr is running with, and since MSC-00... isn't hardcoded anymore, it doesn't know where to send the messages :\

[1]: https://gerrit.osmocom.org/#/c/osmo-hlr/+/13479/



-- 
To view, visit https://gerrit.osmocom.org/13515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1
Gerrit-Change-Number: 13515
Gerrit-PatchSet: 10
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Apr 2019 11:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190409/54822619/attachment.html>


More information about the gerrit-log mailing list