Change in osmo-hlr[master]: USSD: save MO USSD's originating MSC's vlr_number

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Apr 9 08:53:25 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13515 )

Change subject: USSD: save MO USSD's originating MSC's vlr_number
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.osmocom.org/#/c/13515/10/src/gsup_router.c
File src/gsup_router.c:

https://gerrit.osmocom.org/#/c/13515/10/src/gsup_router.c@50
PS10, Line 50: gsup_route_find_by_conn
Doxygen comment is missing.


https://gerrit.osmocom.org/#/c/13515/10/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13515/10/src/hlr_ussd.c@566
PS10, Line 566: LOGPSS(ss, LOGL_DEBUG, "Destination IPA name retrieved from GSUP route: %s\n",
              : 					       osmo_quote_str((const char *)ss->vlr_number, ss->vlr_number_len));
> I have verified that this message shows up in the log, with the correct IPA name, and that *#100# is […]
Did you check if TTCN-3 test cases pass after this change?

As far as I can see, the IPA name is only being stored for 'unstructured' SS (i.e. USSD), but what about 'structured' SS (e.g. call forwarding, call waiting, etc.)?



-- 
To view, visit https://gerrit.osmocom.org/13515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1
Gerrit-Change-Number: 13515
Gerrit-PatchSet: 10
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Apr 2019 08:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190409/716d4446/attachment.html>


More information about the gerrit-log mailing list