Change in osmo-hlr[master]: USSD: save MO USSD's originating MSC's vlr_number

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 8 15:25:21 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13515 )

Change subject: USSD: save MO USSD's originating MSC's vlr_number
......................................................................


Patch Set 7:

(3 comments)

https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@538
PS7, Line 538: 		}
> Need to store ss->vlr_number from conn->* here
wrong again! :/
the function is also called for GSUP from the EUSE, so in fact the place below looks correct. Sorry for the confusion.


https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@562
PS7, Line 562: 				if (gsup->source_name) {
> and drop this chunk
ok so this place is correct, but use conn->where_ever_you_find_the_peers_ipa_name


https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@569
PS7, Line 569: 		} else {
with the limitation that I don't understand this else case



-- 
To view, visit https://gerrit.osmocom.org/13515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1
Gerrit-Change-Number: 13515
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Apr 2019 15:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/6b7e78a6/attachment.html>


More information about the gerrit-log mailing list