Change in osmo-hlr[master]: USSD: save MO USSD's originating MSC's vlr_number

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 8 15:04:57 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13515 )

Change subject: USSD: save MO USSD's originating MSC's vlr_number
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@562
PS7, Line 562: 				if (gsup->source_name) {
> Why do you think we can skip this patch chunk? This is how I've interpreted your comment [1]: […]
gsup->source_name and gsup->destination_name are only included in messages that need routing, i.e. currently exactly for inter-MSC E-interface messages. No other messages contain a source name IE.

Here we are in USSD negotiation land, a completely separate level from inter-MSC routing.

For USSD, you always have the VLR/MSC directly talking to the osmo-hlr, and there is the single GSUP connection on which the response should go back. So that would be stored on the MO USSD request coming in. Otherwise we would lookup the database's vlr_number for the subscriber, but IIUC that doesn't apply here. Definitely never source_name.



-- 
To view, visit https://gerrit.osmocom.org/13515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1
Gerrit-Change-Number: 13515
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Apr 2019 15:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/a682c879/attachment.html>


More information about the gerrit-log mailing list