This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/13515 ) Change subject: USSD: save MO USSD's originating MSC's vlr_number ...................................................................... Patch Set 7: (2 comments) https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c File src/hlr_ussd.c: https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@248 PS7, Line 248: ss->vlr_number_len = strlen(subscr.vlr_number) + 1; > (I still don't like the +1 on the strlen, I think we may need to discuss the blob plan separately so […] Me neither, but at least I've documented the current state here: https://gerrit.osmocom.org/#/c/osmo-hlr/+/13549/ https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@562 PS7, Line 562: if (gsup->source_name) { Why do you think we can skip this patch chunk? This is how I've interpreted your comment [1]: > For all MO USSD sessions, store the originating MSC's vlr_name in ss-> on the first message coming in from the MSC/VLR. ...and isn't the only place where we know if a message is MO USSD or MT USSD right here? And if we do skip it, where should ss->vlr_number get filled out instead? [1]: https://gerrit.osmocom.org/#/c/osmo-hlr/+/13479/5/src/hlr_ussd.c@175 -- To view, visit https://gerrit.osmocom.org/13515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1 Gerrit-Change-Number: 13515 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 08 Apr 2019 14:57:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/2a87bc6c/attachment.htm>