Change in osmo-msc[master]: sgs_iface: fix nullpointer dereference

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 8 14:13:32 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13513 )

Change subject: sgs_iface: fix nullpointer dereference
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13513/2/src/libmsc/sgs_iface.c
File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/#/c/13513/2/src/libmsc/sgs_iface.c@304
PS2, Line 304: 		LOGP(LOGL_NOTICE, DSGS, "Cannot transmit %s: connection dead. Discarding\n",
(could also do the NULL check in the log macro, which would solve all possible null dereferences from SGC logging everywhere)



-- 
To view, visit https://gerrit.osmocom.org/13513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88b95e3f8cd35241ad68f08d94c6ad7067b842e6
Gerrit-Change-Number: 13513
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Apr 2019 14:13:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/1eb3915c/attachment.html>


More information about the gerrit-log mailing list