Change in osmo-bts[master]: oc2gbts_mgr_calib: don't use fsync() on *FILE pointer

dexter gerrit-no-reply at lists.osmocom.org
Mon Apr 8 13:16:23 UTC 2019


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13271 )

Change subject: oc2gbts_mgr_calib: don't use fsync() on *FILE pointer
......................................................................

oc2gbts_mgr_calib: don't use fsync() on *FILE pointer

fsync() takes an integer file descriptor but we have a *FILE pointer
here. Lets use fileno() first to convert the integer file descriptor to
a FILE pointer.

Change-Id: I46ffd8c680ba0b445cbbd133d5ce92b79e3d8d87
---
M src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
index eac8ed1..33c0782 100644
--- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
+++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
@@ -134,7 +134,7 @@
 		fclose(fp);
 		return -EIO;
 	}
-	fsync(fp);
+	fsync(fileno(fp));
 	fclose(fp);
 
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/13271
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46ffd8c680ba0b445cbbd133d5ce92b79e3d8d87
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/149594f6/attachment.html>


More information about the gerrit-log mailing list