Change in osmo-hlr[master]: USSD: don't use gsm0480_msgb_alloc_name()

osmith gerrit-no-reply at lists.osmocom.org
Mon Apr 8 12:42:33 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13548


Change subject: USSD: don't use gsm0480_msgb_alloc_name()
......................................................................

USSD: don't use gsm0480_msgb_alloc_name()

We have nothing to do with GSM 04.80 at the HLR - it's only used to
encapsulate the SS payload between MS and MSC. This is not that
critical, but may be misleading.

Also, gsm0480_msgb_alloc_name() allocates a smaller buffer:

  return msgb_alloc_headroom(1024, 128, name);

than osmo_gsup_client_msgb_alloc() does:

  return msgb_alloc_headroom(4000, 64, __func__);

Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b
---
M src/hlr_ussd.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/48/13548/1

diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c
index cc6aa8a..4f9f023 100644
--- a/src/hlr_ussd.c
+++ b/src/hlr_ussd.c
@@ -241,7 +241,7 @@
 		resp.ss_info_len = msgb_length(ss_msg);
 	}
 
-	resp_msg = gsm0480_msgb_alloc_name(__func__);
+	resp_msg = msgb_alloc_headroom(4000, 64, __func__);
 	OSMO_ASSERT(resp_msg);
 	osmo_gsup_encode(resp_msg, &resp);
 	msgb_free(ss_msg);

-- 
To view, visit https://gerrit.osmocom.org/13548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b
Gerrit-Change-Number: 13548
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/2f019aa3/attachment.html>


More information about the gerrit-log mailing list