Change in libosmocore[master]: fsm: add flag to ensure osmo_fsm_inst_term() happens only once

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 8 07:09:47 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13545 )

Change subject: fsm: add flag to ensure osmo_fsm_inst_term() happens only once
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13545/1/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

https://gerrit.osmocom.org/#/c/13545/1/include/osmocom/core/fsm.h@118
PS1, Line 118: 		bool terminating;
one could use some "uint32_t flags" member and have a single-bit enum type flag in case we'd expect to introduce more flags in the future.  I don't have any such plans, and I don't think you *must* change it.  It's just a thought that occurred to me.



-- 
To view, visit https://gerrit.osmocom.org/13545
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c02d76a86f90c49e0eae2f85db64704c96a7674
Gerrit-Change-Number: 13545
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Mon, 08 Apr 2019 07:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/5ffee568/attachment.html>


More information about the gerrit-log mailing list