Change in osmo-sgsn[master]: gsm0408_rcv_gmm: send Iu-ReleaseCommand upon receiving Attach Complete.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 8 06:40:14 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13544 )

Change subject: gsm0408_rcv_gmm: send Iu-ReleaseCommand upon receiving Attach Complete.
......................................................................


Patch Set 3: Code-Review+1

> > I'm not entirely sure if this is the correct solution or if this
 > is merely a "quick hack" to make it work.
 > I am not sure either. I know only that it solves the problem
 > described in OS#3908. What would be the correct place to ask
 > someone experienced in osmo-sgsn about the right way to add some
 > messages to the "flow"? I guess I should have asked in the mailing
 > list first... answered my own question...

You did everything right, I saw your mailing list posting.  We now "just" have to see when somebody finds the time to investigate deeper and re-read the relevant parts of the specs.  I don't think anyone would be able to respodn to it without that, myself included :)


-- 
To view, visit https://gerrit.osmocom.org/13544
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5053e3cd655d08ff3fd0fefa48325fabb1797c8
Gerrit-Change-Number: 13544
Gerrit-PatchSet: 3
Gerrit-Owner: Mykola Shchetinin <mykola at pentonet.com>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Mykola Shchetinin <mykola at pentonet.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Mon, 08 Apr 2019 06:40:14 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/1306060e/attachment.html>


More information about the gerrit-log mailing list