Change in libosmocore[master]: fsm: support graceful osmo_fsm_inst_term() cascades

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Apr 7 22:30:49 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13392 )

Change subject: fsm: support graceful osmo_fsm_inst_term() cascades
......................................................................


Patch Set 4:

> Patch Set 4:
> new libraries should always run old programs fine.

ack, got it now.
So we should make this feature a runtime switch.

It would suffice to have one global boolean variable for all FSMs.
As soon as a client program sets that to true ("recommended use") fsm.c uses the new method. The osmo-msc source tree can then decide itself from which revision on it switches to the new FSM termination behavior.

It could also be an argument passed to osmo_fsm_inst_term2(), or a flag set in each FSM definition. But that would become a lot more complex and patch prone than one global switch.


-- 
To view, visit https://gerrit.osmocom.org/13392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eda67540a1cd444491beb7856b9fcd0a3143b18
Gerrit-Change-Number: 13392
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Sun, 07 Apr 2019 22:30:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190407/20c82644/attachment.html>


More information about the gerrit-log mailing list