Change in osmo-bsc[master]: osmo_bsc_lcls.c: cosmetic: make Coverity happy

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Apr 6 20:58:45 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13533 )

Change subject: osmo_bsc_lcls.c: cosmetic: make Coverity happy
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13533/2/src/osmo-bsc/osmo_bsc_lcls.c
File src/osmo-bsc/osmo_bsc_lcls.c:

https://gerrit.osmocom.org/#/c/13533/2/src/osmo-bsc/osmo_bsc_lcls.c@427
PS2, Line 427: 		if (lcls_handle_cfg_update(conn, data) != 0)
> So it cries because in first time this return here makes no sense. […]
No, it actually cries because we do 'return' in both cases: if the condition is true, or the condition is false. The benefit of using 'break' is that one can still add some code after the 'switch' statement, and it won't be unreachable in such cases.



-- 
To view, visit https://gerrit.osmocom.org/13533
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556
Gerrit-Change-Number: 13533
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 06 Apr 2019 20:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/4344df89/attachment.html>


More information about the gerrit-log mailing list