Change in libosmo-abis[master]: ipa_keepalive_fsm: Fix OSMO_IPA_KA_E_STOP allstate event

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Apr 6 19:21:02 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13540 )

Change subject: ipa_keepalive_fsm: Fix OSMO_IPA_KA_E_STOP allstate event
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13540/1/src/input/ipa_keepalive.c
File src/input/ipa_keepalive.c:

https://gerrit.osmocom.org/#/c/13540/1/src/input/ipa_keepalive.c@192
PS1, Line 192: allstate_event_mask
Hmm, maybe we should warn the API user from fsm.c when the allstate_action is set, but allstate_event_mask is 0x00?



-- 
To view, visit https://gerrit.osmocom.org/13540
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd991bdacb7bab794878e47c7797fecf8b9286
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 19:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/63be7168/attachment.html>


More information about the gerrit-log mailing list