Change in libosmocore[master]: vty/talloc_ctx_vty.c: use REG_NOSUB flag of regcomp()

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Apr 6 16:17:06 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13536 )

Change subject: vty/talloc_ctx_vty.c: use REG_NOSUB flag of regcomp()
......................................................................


Patch Set 1: Code-Review+2

looks great.  Makes sense to also check our other regcomp invocations, as (I think) we don't need the position of matches in all cases:

openbsc/contrib/nat/test_regexp.c:      if (regcomp(&reg, argv[1], REG_EXTENDED) != 0) {
openbsc/src/libcommon/gsm_data.c:               ret = regcomp(reg, argv[0], 0);
openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c:             if (regcomp(&entry->msisdn_reg, regexp, 0) != 0) {
openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c:             if (regcomp(&entry->num_reg, cfg_entry->option, REG_EXTENDED) != 0) {
osmo-bsc/src/osmo-bsc/gsm_data.c:                ret = regcomp(reg, argv[0], 0);
osmo-sgsn/src/gprs/gb_proxy_patch.c:      rc = regcomp(&match->re_comp, filter,


-- 
To view, visit https://gerrit.osmocom.org/13536
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55ffe64cc1a35dd83f61dbb0f9828aa676696f9
Gerrit-Change-Number: 13536
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Sat, 06 Apr 2019 16:17:06 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/ed853691/attachment.html>


More information about the gerrit-log mailing list