Change in osmo-bsc[master]: osmo_bsc_lcls.c: cosmetic: make Coverity happy

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Apr 6 11:59:22 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13533


Change subject: osmo_bsc_lcls.c: cosmetic: make Coverity happy
......................................................................

osmo_bsc_lcls.c: cosmetic: make Coverity happy

The 'return' that makes Coverity angry can be safely replaced by 'break'.

Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556
Fixes: CID#188873 Identical code for different branches
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/13533/1

diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index c1f62dc..9cd13a7 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -471,7 +471,7 @@
 	case LCLS_EV_UPDATE_CFG_CSC:
 		if (lcls_handle_cfg_update(conn, data) != 0)
 			return;
-		return;
+		break;
 	case LCLS_EV_APPLY_CFG_CSC:
 		if (lcls_perform_correlation(conn) != 0) {
 			/* no correlation result: Remain in NOT_POSSIBLE_LS */

-- 
To view, visit https://gerrit.osmocom.org/13533
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556
Gerrit-Change-Number: 13533
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/e908c082/attachment.html>


More information about the gerrit-log mailing list