This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13522 ) Change subject: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic ...................................................................... abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic Change-Id: I1ce97fc28a608894c8dfa3bbc55032e66bc44e5b --- M src/osmo-bsc/abis_nm.c 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index a9b5aa5..5be207f 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -2815,9 +2815,8 @@ oh->mdisc = ABIS_OM_MDISC_MANUF; /* add the ip.access magic */ - data = msgb_put(msg, sizeof(abis_nm_ipa_magic)+1); - *data++ = sizeof(abis_nm_ipa_magic); - memcpy(data, abis_nm_ipa_magic, sizeof(abis_nm_ipa_magic)); + msgb_lv_put(msg, sizeof(abis_nm_ipa_magic), + (const uint8_t *) abis_nm_ipa_magic); /* fill the 12.21 FOM header */ foh = (struct abis_om_fom_hdr *) msgb_put(msg, sizeof(*foh)); -- To view, visit https://gerrit.osmocom.org/13522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1ce97fc28a608894c8dfa3bbc55032e66bc44e5b Gerrit-Change-Number: 13522 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/9b0dbfed/attachment.htm>