This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13519 ) Change subject: abis_nm.c: use proper format specifiers for BTS / TRX number ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/13519/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/13519/1/src/osmo-bsc/abis_nm.c@1716 PS1, Line 1716: DEBUGP(DNM, "Get Attr (bts=%u)\n", bts->nr); > Making sure it compiles fine if you ever happen to use some broken compiler which doesn't like using […] I wouldn't go that far, honestly. If at all, we could consider using "unsigned int" as type. uint8_t makes sense for fields that are encoded as 8bit value in some protocol header, but for internal values/data structures we're of course free to use whatever types you want. I used uint8_t because the numbers in Abis OML are restricted to that size. Irrespective of the above: I'm *perfectly* fine with using %u for uint8_t. -- To view, visit https://gerrit.osmocom.org/13519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I429d00d1393c221070e4c9e0997cbd14ae96103e Gerrit-Change-Number: 13519 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Sat, 06 Apr 2019 10:32:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/6520d08a/attachment.htm>