Change in osmo-bsc[master]: abis_nm.c: fix broken logging in abis_nm_rx_ipacc()

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Apr 4 18:45:38 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13523 )

Change subject: abis_nm.c: fix broken logging in abis_nm_rx_ipacc()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13523/2/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/13523/2/src/osmo-bsc/abis_nm.c@2712
PS2, Line 2712: \n
I am intentionally adding this EOL, because the most branches of switch (excluding NM_MT_IPACC_RSL_CONNECT_ACK and the 'default') are using LOGPFOH() and LOGPFOH() to print the message type. As a result, we get the following:

  DNM DEBUG <0004> abis_nm.c:2716 OC=GPRS-CELL(f1) INST=(00,00,ff): IPACCESS(0xf6): DNM DEBUG <0004> abis_nm.c:2769 OC=GPRS-CELL(f1) INST=(00,00,ff): SET ATTR ACK

After this patch, we would get the following:

  DNM DEBUG <0004> abis_nm.c:2713 OC=GPRS-NSE(f0) INST=(00,ff,ff): Rx IPACCESS(0xf6): 9d 00 02 00 65 a0 00 07 03 03 03 03 1e 03 0a a1 00 0b 03 03 03 03 03 0a 03 0a 03 0a 03
  DNM DEBUG <0004> abis_nm.c:2766 OC=GPRS-NSE(f0) INST=(00,ff,ff): SET ATTR ACK



-- 
To view, visit https://gerrit.osmocom.org/13523
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65ff2968523a90607bafd44e6f4f3d3e29ff73ef
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Apr 2019 18:45:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190404/95f20c2f/attachment.html>


More information about the gerrit-log mailing list