Change in osmo-bsc[master]: abis_nm.c: use proper format specifiers for BTS / TRX number

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Apr 4 14:26:22 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13519 )

Change subject: abis_nm.c: use proper format specifiers for BTS / TRX number
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13519/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/13519/1/src/osmo-bsc/abis_nm.c@1716
PS1, Line 1716: 	DEBUGP(DNM, "Get Attr (bts=%u)\n", bts->nr);
> it should actually be [...] PRIu8

Ideally, yes. But '%u' also works.

What are the advantages of PRIu8 in this particular case?
And whet are the disadvantages of '%u' here?



-- 
To view, visit https://gerrit.osmocom.org/13519
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I429d00d1393c221070e4c9e0997cbd14ae96103e
Gerrit-Change-Number: 13519
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2019 14:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190404/5c98b70f/attachment.html>


More information about the gerrit-log mailing list