Change in docker-playground[master]: make/Makefile: fix recursive 'PULL' error

osmith gerrit-no-reply at lists.osmocom.org
Thu Apr 4 08:26:15 UTC 2019


osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13512 )

Change subject: make/Makefile: fix recursive 'PULL' error
......................................................................

make/Makefile: fix recursive 'PULL' error

Don't abort with the following error, when running 'make' without
setting the PULL environment variable:

 ../make/Makefile:20: *** Recursive variable 'PULL' references itself (eventually). Stop.

This fixes a regression from Change-Id
I1076bbb7d77bdc99f5d60d641c09ce965fb9dfc6.

Related: OS#3869
Change-Id: I4b4772e9ed6e07ab00943154265c9cbdea22a2f5
---
M make/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Verified



diff --git a/make/Makefile b/make/Makefile
index d4e3c22..7dfa795 100644
--- a/make/Makefile
+++ b/make/Makefile
@@ -17,7 +17,7 @@
 USERNAME?=$(USER)
 NAME?=$(shell basename $(CURDIR))
 OSMO_TTCN3_BRANCH?=master
-PULL?=$(PULL)
+PULL?=
 
 RELEASE_SUPPORT := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))/.make-release-support
 IMAGE?=$(REGISTRY_HOST)/$(USER)/$(NAME)

-- 
To view, visit https://gerrit.osmocom.org/13512
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b4772e9ed6e07ab00943154265c9cbdea22a2f5
Gerrit-Change-Number: 13512
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190404/313f369a/attachment.html>


More information about the gerrit-log mailing list