Change in libosmocore[master]: make use of OTC_GLOBAL when allocating library-internal contexts

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Apr 3 16:37:06 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13338 )

Change subject: make use of OTC_GLOBAL when allocating library-internal contexts
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/13338/5/src/gsm/lapd_core.c
File src/gsm/lapd_core.c:

https://gerrit.osmocom.org/#/c/13338/5/src/gsm/lapd_core.c@255
PS5, Line 255: __thread
Looks like it should have been done in https://gerrit.osmocom.org/#/c/libosmocore/+/13436/.


https://gerrit.osmocom.org/#/c/13338/5/src/logging.c
File src/logging.c:

https://gerrit.osmocom.org/#/c/13338/5/src/logging.c@962
PS5, Line 962: ctx
Should we mark it as '__unused' then?



-- 
To view, visit https://gerrit.osmocom.org/13338
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48f475efd3ee0d5120b8fc30861e852d1a6920b1
Gerrit-Change-Number: 13338
Gerrit-PatchSet: 5
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 16:37:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190403/10c3c1a3/attachment.html>


More information about the gerrit-log mailing list