Change in libosmo-sccp[master]: Cosmetic: sccp_scoc: fix local reference comments

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 3 14:48:12 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13506 )

Change subject: Cosmetic: sccp_scoc: fix local reference comments
......................................................................

Cosmetic: sccp_scoc: fix local reference comments

Remove all comments, that claim conn_id is the local reference. This
is only a hack, and should not be something to rely on. A properly
separated local reference will be introduced shortly.

Related: OS#3871
Change-Id: I900124037da76caaaf5ecee323eb82e1c6d2e368
---
M src/sccp_internal.h
M src/sccp_scoc.c
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/sccp_internal.h b/src/sccp_internal.h
index 000f0f7..ad8a6fd 100644
--- a/src/sccp_internal.h
+++ b/src/sccp_internal.h
@@ -47,7 +47,7 @@
 	struct llist_head users;
 	/* routing context to be used in all outbound messages */
 	uint32_t route_ctx;
-	/* next local reference to allocate */
+	/* next connection ID to allocate */
 	uint32_t next_id;
 	struct osmo_ss7_instance *ss7;
 	void *priv;
diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index e58251f..726426c 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -458,7 +458,7 @@
 
 #define INIT_TIMER(x, fn, priv)		do { (x)->cb = fn; (x)->data = priv; } while (0)
 
-/* allocate + init a SCCP Connection with given ID (local reference) */
+/* allocate + init a SCCP Connection with given ID */
 static struct sccp_connection *conn_create_id(struct osmo_sccp_instance *inst,
 					      uint32_t conn_id)
 {
@@ -480,7 +480,7 @@
 	/* this might change at runtime, as it is not a constant :/ */
 	sccp_scoc_fsm.log_subsys = DLSCCP;
 
-	/* we simply use the local reference as FSM instance name */
+	/* we simply use the connection ID as FSM instance name */
 	snprintf(name, sizeof(name), "%u", conn->conn_id);
 	conn->fi = osmo_fsm_inst_alloc(&sccp_scoc_fsm, conn, conn,
 					LOGL_DEBUG, name);
@@ -493,7 +493,7 @@
 	return conn;
 }
 
-/* Search for next free connection ID (local reference) and allocate conn */
+/* Search for next free connection ID and allocate conn */
 static struct sccp_connection *conn_create(struct osmo_sccp_instance *inst)
 {
 	uint32_t conn_id;

-- 
To view, visit https://gerrit.osmocom.org/13506
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I900124037da76caaaf5ecee323eb82e1c6d2e368
Gerrit-Change-Number: 13506
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190403/d2a43a3b/attachment.html>


More information about the gerrit-log mailing list