Change in osmo-hlr[master]: gsup_router.c: gsup_route_find(): support blob

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Apr 2 07:05:27 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13048 )

Change subject: gsup_router.c: gsup_route_find(): support blob
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/13048/2/src/gsup_router.c
File src/gsup_router.c:

https://gerrit.osmocom.org/#/c/13048/2/src/gsup_router.c@43
PS2, Line 43: talloc_total_size
You could alternatively extend struct 'gsup_route' with 'addr_len', and modify gsup_route_add() to store the address length there. Calling talloc_total_size() comes at a higher price...


https://gerrit.osmocom.org/#/c/13048/2/src/gsup_router.c@45
PS2, Line 45: a lot of code assumes that addr is also nul-terminated
Wait, your previous comment also states that "gr->addr is a nul-terminated string" o_O.


https://gerrit.osmocom.org/#/c/13048/2/src/gsup_router.c@49
PS2, Line 49: Compare addr as non-nul-terminated blob
Wouldn't this cause a collision when e.g. both (read in hex):

  - 0xff, 0x00, 0x00, 0xbb, 0xaa, 0xff,
  - 0xff, 0x00, 0x00, 0xbb, 0xaa, 0x77,

are considered as equal?



-- 
To view, visit https://gerrit.osmocom.org/13048
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01a45900e14d41bcd338f50ad85d9fabf2c61405
Gerrit-Change-Number: 13048
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 07:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190402/8c1aa61e/attachment.html>


More information about the gerrit-log mailing list