Change in osmo-hlr[master]: fix USSD routing to multiple MSC

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Apr 2 06:26:08 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13479 )

Change subject: fix USSD routing to multiple MSC
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@335
PS4, Line 335: ss->subscr = NULL;
I think doing this manually is not a good idea... Instead, you could extend struct 'ss_session' with a kind of counter, and decrease it right in ss_gsup_send(). As soon as the counter reaches 0, we do the database lookup again.

Alternatively, you can measure the time spent since the last response, so if time > X => we do the database lookup.


https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@338
PS4, Line 338: 		ss_tx_error(ss, true, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER);
> should probably also somehow remember which MSC initiated the session?

ACK.



-- 
To view, visit https://gerrit.osmocom.org/13479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3
Gerrit-Change-Number: 13479
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 06:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190402/8d7b3150/attachment.html>


More information about the gerrit-log mailing list