Change in osmo-msc[master]: a_iface_bssap: add context information to log output

dexter gerrit-no-reply at lists.osmocom.org
Mon Apr 1 15:46:50 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13319 )

Change subject: a_iface_bssap: add context information to log output
......................................................................


Patch Set 5:

(2 comments)

> I completely agree with the intent, that's why I have added context
 > to the logging in the current refactoring of osmo-msc, on branch
 > neels/ho. If anything is still missing on that branch, let's apply
 > it there instead of introducing merge conflicts. I'm sorry to block
 > your work, but I think the osmo-msc status has been clear?

I see, then we probably abandon this as well.

https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c@167
PS2, Line 167: 		return;
> That seems redundant: it'll be printed as part of the prefix anyway.
Done


https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c@167
PS2, Line 167: 		return;
> the point here was that the %s / osmo_sccp_addr_name() is redundant.  Not the enitre log line. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/13319
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I704954edc8677688fc7cccd2b23d2aff958ebf32
Gerrit-Change-Number: 13319
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <suraev at alumni.ntnu.no>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 01 Apr 2019 15:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190401/322145dd/attachment.html>


More information about the gerrit-log mailing list