Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

dexter gerrit-no-reply at lists.osmocom.org
Mon Apr 1 14:43:27 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13366 )

Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length
......................................................................


Patch Set 3:

(2 comments)

> Build Successful
 > 
 > https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/67/ : SUCCESS'
 >  --verified 1 --code-review 0

https://gerrit.osmocom.org/#/c/13366/3/pySim/cards.py
File pySim/cards.py:

https://gerrit.osmocom.org/#/c/13366/3/pySim/cards.py@121
PS3, Line 121: 	def update_ad(self, mnc):
> so this is part of the generic "card" class...
Done


https://gerrit.osmocom.org/#/c/13366/3/pySim/cards.py@603
PS3, Line 603:                 # EF.AD
> but it's used only from the sysmoUSIM-SJS1 specicic code. […]
The file is specified by 3GPP TS 31.102, chapter 4.2.18. However this is an USIM spec. That probably also explains why fakemagicsim and sysmo-usim-gr1 have short files. (I have now also added the writing EF.AD for wavemobile-sim in #13478.)



-- 
To view, visit https://gerrit.osmocom.org/13366
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I827092b2c7f7952f54b2d9f8dbda419a0dbfaf65
Gerrit-Change-Number: 13366
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Apr 2019 14:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190401/ae46055d/attachment.html>


More information about the gerrit-log mailing list