Change in osmocom-bb[master]: trxcon/scheduler: fix: prevent division by zero

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Sep 30 12:32:27 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11157 )

Change subject: trxcon/scheduler: fix: prevent division by zero
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11157/1/src/host/trxcon/sched_lchan_common.c
File src/host/trxcon/sched_lchan_common.c:

https://gerrit.osmocom.org/#/c/11157/1/src/host/trxcon/sched_lchan_common.c@101
PS1, Line 101: 		-(lchan->meas.rssi_sum / lchan->meas.rssi_num) : 0;
is '0' really the lowest received level at this point? I don't recall the L1CTL conventions right now.  I just think that if no measurement exists, we should assume the worst ?



-- 
To view, visit https://gerrit.osmocom.org/11157
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4659de899411ec1ba1718fdcb40aec562dbfd65
Gerrit-Change-Number: 11157
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Sun, 30 Sep 2018 12:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180930/14807f7c/attachment.htm>


More information about the gerrit-log mailing list