Change in mncc-python[master]: *.py: use proper '#!/usr/bin/env' shebang

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Sep 30 12:30:37 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11152 )

Change subject: *.py: use proper '#!/usr/bin/env' shebang
......................................................................

*.py: use proper '#!/usr/bin/env' shebang

Using hard-coded paths in shebang is a bad idea, because on different
systems Python interpreter can be installed in different places. See:

https://mail.python.org/pipermail/tutor/2007-June/054816.html

Change-Id: Ib729ece0c95254dc2b235f90eb731681df955bd1
---
M gsm_call_fsm.py
M mncc_sock.py
M mncc_test.py
M smpp_test.py
4 files changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/gsm_call_fsm.py b/gsm_call_fsm.py
index 167a805..c62df0c 100644
--- a/gsm_call_fsm.py
+++ b/gsm_call_fsm.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python2
 
 # Python implementation of GSM 04.08 call state machine for use with
 # OsmoNITB MNCC interface
diff --git a/mncc_sock.py b/mncc_sock.py
index 3cc1ba1..22fe034 100644
--- a/mncc_sock.py
+++ b/mncc_sock.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python2
 
 # Python interface to OsmoNITB MNCC (Mobile Network Call Control)
 # interface
diff --git a/mncc_test.py b/mncc_test.py
index f9d102b..de35fe6 100755
--- a/mncc_test.py
+++ b/mncc_test.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python2
 
 # Python testing tool for establishing calls via the OsmoNITB MNCC
 # interface.
diff --git a/smpp_test.py b/smpp_test.py
index e2c2ee0..181f60d 100755
--- a/smpp_test.py
+++ b/smpp_test.py
@@ -1,4 +1,5 @@
-#!/usr/bin/python
+#!/usr/bin/env python2
+
 import logging
 import sys
 

-- 
To view, visit https://gerrit.osmocom.org/11152
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib729ece0c95254dc2b235f90eb731681df955bd1
Gerrit-Change-Number: 11152
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180930/66ac2209/attachment.htm>


More information about the gerrit-log mailing list