This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11138 )
Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:
https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@182
PS4, Line 182: * FIXME: this would require having access to the trx_instance,
> Let's do it later in a separate change.
According to the specs (3GPP TS 05.08) the maintenance of both
timing advance and MS power control should be done separately
per each pair of DCCH/TCH and SACCH. This means it would be
good to store both TA and PWR in the corresponding lchans
instead of storing in a single common trx_instance...
https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@255
PS4, Line 255: llist_for_each_entry(prim, queue, list) {
> I think it would be more elegant to have a second queue for SACCH so we don't have to scan the (shar […]
It could be done this way, but we would still have the need
to look for the relevant messages within this SACCH queue.
Why? Because a SACCH channel accomplishes either a DCCH,
or a TCH channel, so if one would have a few independent
connections (DCCH and/or TCH), e.g. for testing, then it
is important to distinguish between multiple SACCH channels.
--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 29 Sep 2018 06:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180929/3c4aacdc/attachment.htm>