Change in osmo-sgsn[master]: gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 28 23:25:27 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10033 )

Change subject: gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL
......................................................................

gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL

NET_FAIL will result in asking again and again. Reject with IMPL_DETACHED to drop the
MS completely.

Change-Id: I195d533e330a4b577cad80c7e757d481f9c837df
---
M src/gprs/gprs_gmm.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index a363c70..a86fe2b 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1862,7 +1862,7 @@
 			ctx = sgsn_mm_ctx_by_imsi(mi_string);
 		if (!ctx) {
 			/* FIXME: We need to have a context for service request? */
-			reject_cause = GMM_CAUSE_NET_FAIL;
+			reject_cause = GMM_CAUSE_IMPL_DETACHED;
 			goto rejected;
 		}
 		msgid2mmctx(ctx, msg);
@@ -1875,7 +1875,7 @@
 			ctx = sgsn_mm_ctx_by_ptmsi(tmsi);
 		if (!ctx) {
 			/* FIXME: We need to have a context for service request? */
-			reject_cause = GMM_CAUSE_NET_FAIL;
+			reject_cause = GMM_CAUSE_IMPL_DETACHED;
 			goto rejected;
 		}
 		msgid2mmctx(ctx, msg);

-- 
To view, visit https://gerrit.osmocom.org/10033
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I195d533e330a4b577cad80c7e757d481f9c837df
Gerrit-Change-Number: 10033
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/3ff913a5/attachment.htm>


More information about the gerrit-log mailing list