This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11138 )
Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:
https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@255
PS4, Line 255: llist_for_each_entry(prim, queue, list) {
I think it would be more elegant to have a second queue for SACCH so we don't have to scan the (shared) queue and filter for SACCH messages, but simply can directly look at a queue containing only "relevant" messages. But that's just a matter of taste and doesn't have to happen at all, particularly not in this patch.
--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/3bb682bf/attachment.htm>