Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Sep 28 17:45:16 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11149 )

Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@11
PS1, Line 11: dummy
> As I already mentioned in 11138, the firmware actually […]
in firmware case, the cached message is also removed during L1CTL_DM_REL_REQ, because it is called this way: l1a_meas_msgb_set(NULL);

In turn L1CTL_RESET_REQ will reset variables used in tx_power.

So I think we need to keep this commit, but I can add something like:
 "If for whatever reason (eg. CPU scheduling saturation) the L1CTL cli (TTCN3) doesn't send Measurement Reports on time and no previous one is cached or has been erased by L1CTL_DM_REL_REQ,"


https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@13
PS1, Line 13: Those
> Only dummy MRs are filled with the actual parameters, […]
Agree. That's more a less what I'm saying here. I need to add to the tail: "in order to send expected values in case the cache is empty and we don't send the Measurement Report through L1CTL on time."


https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn@1371
PS1, Line 1371: 	f_L1CTL_PARAM(L1CTL, ta, tx_power);
> Why do we need both variables? […]
I'll pass the variables directly.



-- 
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/58736a3a/attachment.htm>


More information about the gerrit-log mailing list