Change in osmo-msc[master]: mncc: fix byte ordering of IP-Address in mncc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Sep 28 09:04:54 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11139


Change subject: mncc: fix byte ordering of IP-Address in mncc
......................................................................

mncc: fix byte ordering of IP-Address in mncc

At the moment osmo-msc populates the member ip in struct gsm_mncc_rtp
with the wrong byte ordering. This causes LCR or
osmo-sip-connector to receive the IP address in the wrong order, which
eventually leads into a reversed IP address in the SDP part of the SIP
messages.

Change-Id: I86148179b549b511528e4c65213eb6c204cc609e
Related: OS#3431
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/39/11139/1

diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 2c17e22..19e6cba 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1606,7 +1606,7 @@
 
 	rtp->callref = callref;
 	rtp->msg_type = cmd;
-	rtp->ip = addr;
+	rtp->ip = osmo_htonl(addr);
 	rtp->port = port;
 	rtp->payload_type = payload_type;
 	rtp->payload_msg_type = payload_msg_type;

-- 
To view, visit https://gerrit.osmocom.org/11139
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86148179b549b511528e4c65213eb6c204cc609e
Gerrit-Change-Number: 11139
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/b80fdc4e/attachment.htm>


More information about the gerrit-log mailing list