Change in libosmo-sccp[master]: make SCCP timers configurable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Sep 27 14:15:04 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11119 )

Change subject: make SCCP timers configurable
......................................................................


Patch Set 3:

just use seconds.  I'm not sure where the desire for sub-second resolution comes from?  I don't think this would ever at all make any sense on the SCCP layer.  You are at a "layer 3/4" of a protocol that is used in global signaling. You can have any number of routed (mostly) terrestrial links.  The latency/RTT is very likely in the hundreds of milli-seconds in many use cases.

Hence I'd be surprised if the SCCP spec contained any sub-second-resolution timers, or even only any recommendation to set a timer to a fractional second.  Please let me know if I'm missing something.

Otherwise, I really don't see the point.  And btw, the NS/libosmogb code also has timers which are named, and we also don't have different units there.  So I really see no reason for all this complexity.  We have *tons* of work to do rather such superficial cosmetics that just consume time - and then even have a discussion about it which consumes more time.  Sorry.


-- 
To view, visit https://gerrit.osmocom.org/11119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28a7362aa838e648ecc9b26ee53dbcade81a9d65
Gerrit-Change-Number: 11119
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Sep 2018 14:15:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/3bfd7979/attachment.htm>


More information about the gerrit-log mailing list